🐛 correction of issue #2617 selected fixed subnet not applied #2639
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
|
|
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: no
k8s-ci-robot
added
needs-ok-to-test
|
Hi @nonowheels63. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nonowheels63
force-pushed
the
bug-2617-main
branch
from
2fa0333 to
0dcc046
Compare
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
nonowheels63
force-pushed
the
bug-2617-main
branch
from
b50c804 to
d363b1e
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
@bnallapeta: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| serverPort.Network = &infrav1.NetworkParam{ | ||
| ID: &openStackCluster.Status.Network.ID, | ||
| } | ||
| if len(fixedIPs) > 0 { |
There was a problem hiding this comment.
nit: unnecessary if. You can execute the line below unconditionally.
| @@ -520,21 +520,38 @@ func openStackMachineSpecToOpenStackServerSpec(openStackMachineSpec *infrav1.Ope | |||
| if len(openStackMachineSpec.Ports) == 0 { | |||
| serverPorts = make([]infrav1.PortOpts, 1) | |||
| } | |||
|
|
|||
| var fixedIPs []infrav1.FixedIP | |||
There was a problem hiding this comment.
nit: Could we rename this to defaultSubnets or clusterSubnets or something more indicative of what it is? The generic name made this harder for me to read.
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This PR enable the usage of a provided subnet when it is provided. At first the provided network wasn't used when the there where multiple subnet attached to the network, one random subnet was used (the first returned by the api).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2617
Special notes for your reviewer:
This PR is related to #2624.
I don't know if i have to close the last PR ?!
TODOs:
/hold